Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add register_json #458

Merged
merged 1 commit into from
Aug 17, 2023
Merged

feat: add register_json #458

merged 1 commit into from
Aug 17, 2023

Conversation

mesejo
Copy link
Contributor

@mesejo mesejo commented Aug 12, 2023

Which issue does this PR close?

This PR closes the register_json request in #24.

What changes are included in this PR?

Adds the register_json function to the SessionContext

Are there any user-facing changes?

Yes

andygrove
andygrove approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @mesejo

@andygrove andygrove merged commit 217ede8 into apache:main Aug 17, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andygrove andygrove andygrove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mesejo @andygrove